TST Add basic common test infrastructure #6107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It now iterates over all (or at least most?) estimators in cuml and checks them. Unfortunately a lot of the tests fail and locally I even get a rmm error which crashes pytest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #6105
This adds a test that uses the test infrastructure that scikit-learn provides to find out if an estimator is compatible with scikit-learn. Short explanation https://scikit-learn.org/dev/developers/develop.html#rolling-your-own-estimator and we use https://scikit-learn.org/dev/modules/generated/sklearn.utils.estimator_checks.parametrize_with_checks.html#sklearn.utils.estimator_checks.parametrize_with_checks here to have a test that is parametrized by estimator and check. This makes it easy to see what is failing.
I've only added
LogisticRegressionfor the moment, mostly because I wanted to see what other people think of this. I think it would be useful for issues like #6105 to find out which estimators are/aren't compatible, fix them and make sure they stay compatible. Fixing some of the failures would probably make it easier for users to swap scikit-learn and cuml without big effort. A downside is that right now a lot of the checks fail.WDYT?